feat(@angular-devkit/build-angular): ng extract-i18n support json and arb

[wenqi73]

@angular/localize supports extracting as json file, but CLI does not support this.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[wenqi73]

@googlebot I fixed it.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[petebacondarwin]

If you are extracting to JSON then surely you will need to implement merging translations stored in JSON too? See https://github.com/angular/angular/blob/master/packages/localize/src/tools/src/translate/translation_files/translation_parsers/simple_json_translation_parser.ts
Also, we recently implemented ARB format, which is another form of JSON that might be worth supporting: https://github.com/angular/angular/blob/master/packages/localize/src/tools/src/extract/translation_files/arb_translation_serializer.ts and https://github.com/angular/angular/blob/master/packages/localize/src/tools/src/translate/translation_files/translation_parsers/arb_translation_parser.ts

[wenqi73]

@petebacondarwin What do you mean by "implement merging translations"? Could you tell me the details?

[petebacondarwin]

@wenqi73 - there are two main processes in i18n: extraction and merging (sometimes called translation or inlining). The extraction process involves parsing the code for $localize calls and rendering translation files (e.g. XLIFF) containing all the i18n messages. The merging process involves parsing the code for $localize calls and replacing those calls with translated messages, where the translated messages are read in from translation files (e.g. XLIFF).

When supporting a particular translation file format, we need to provide a serializer (used when extracting) and a parser (used when merging).

[wenqi73]

@petebacondarwin It already has the JSON parser in cli,

angular-cli/packages/angular_devkit/build_angular/src/utils/load-translations.ts

Line 69 in 97aa1fb

json: new (await import(

so just need to add serializer? And now in my project I also use JSON files as translation files with localize-extract, it works fine!

[petebacondarwin]

Gadzooks! You are right! I didn't see that. Nice. OK so you are good just to add the serializer. Sorry for the noise.

[wenqi73]

@petebacondarwin I have added arb format, please have a look😄

[petebacondarwin]

LGTM.
We should then document these options too... See https://next.angular.io/cli/extract-i18n. I think that these are specfiied here https://github.com/angular/angular-cli/blob/9c57e45d4e4f433220d909ffb10c1c38f02093c4/packages/angular_devkit/build_angular/src/extract-i18n/schema.json

[clydin]

Can you also add an E2E test file for each of the formats?
You can use the following test file as a base (and the new tests can be placed in the same directory):
https://github.com/angular/angular-cli/blob/cfb368408b532e488acaa1a5a921240f0dc7dfad/tests/legacy-cli/e2e/tests/i18n/ivy-localize-dl-xmb.ts

[clydin]

Code changes look good.
Can you re-structure the commits so that the PR contains two feature commits: one for JSON and one for ARB (with the tests for each included in their respective commits)?

With that adjustment this should be good to be merged.
Thank you for the contribution.

[wenqi73]

@clydin Commits have been readjusted.

[clydin]

LGTM.

Thanks again for the contribution.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}