Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

This change adds a unit tests for the browser builder's extractLicenses option using the builder test harness.

@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release preserve commits labels Jan 11, 2021
@google-cla google-cla bot added the cla: yes label Jan 11, 2021
@alan-agius4 alan-agius4 changed the title test(@angular-devkit/buid-angular): change extractLicenses unit test to use build harness test(@angular-devkit/build-angular): change extractLicenses unit test to use build harness Jan 11, 2021
@alan-agius4 alan-agius4 requested a review from clydin January 11, 2021 11:41
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one more for the not present state (tests the default value)?

…st to use build harness

This change adds a unit tests for the browser builder's extractLicenses option using the builder test harness.
@alan-agius4
Copy link
Collaborator Author

@clydin PTAL.

@alan-agius4 alan-agius4 requested a review from clydin January 11, 2021 18:15
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 11, 2021
@alan-agius4 alan-agius4 merged commit a266f55 into angular:master Jan 11, 2021
@alan-agius4 alan-agius4 deleted the extractLicenses-harness branch January 11, 2021 18:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants