Skip to content

refactor(@ngtools/webpack): replace deprecated TypeScript methods #19883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Jan 28, 2021
Merged

refactor(@ngtools/webpack): replace deprecated TypeScript methods #19883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/ngtools/webpack/src/ivy/transformation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,26 @@ export function replaceBootstrap(
let bootstrapImport: ts.ImportDeclaration | undefined;
let bootstrapNamespace: ts.Identifier | undefined;
const replacedNodes: ts.Node[] = [];
const nodeFactory = context.factory;

const visitNode: ts.Visitor = (node: ts.Node) => {
if (ts.isCallExpression(node) && ts.isIdentifier(node.expression)) {
const target = node.expression;
if (target.text === 'platformBrowserDynamic') {
if (!bootstrapNamespace) {
bootstrapNamespace = ts.createUniqueName('__NgCli_bootstrap_');
bootstrapImport = ts.createImportDeclaration(
bootstrapNamespace = nodeFactory.createUniqueName('__NgCli_bootstrap_');
bootstrapImport = nodeFactory.createImportDeclaration(
undefined,
undefined,
ts.createImportClause(undefined, ts.createNamespaceImport(bootstrapNamespace)),
ts.createLiteral('@angular/platform-browser'),
nodeFactory.createImportClause(false, undefined, nodeFactory.createNamespaceImport(bootstrapNamespace)),
nodeFactory.createStringLiteral('@angular/platform-browser'),
);
}
replacedNodes.push(target);

return ts.updateCall(
return nodeFactory.updateCallExpression(
node,
ts.createPropertyAccess(bootstrapNamespace, 'platformBrowser'),
nodeFactory.createPropertyAccessExpression(bootstrapNamespace, 'platformBrowser'),
node.typeArguments,
node.arguments,
);
Expand Down Expand Up @@ -126,10 +127,10 @@ export function replaceBootstrap(
}

// Add new platform browser import
return ts.updateSourceFileNode(
return nodeFactory.updateSourceFile(
updatedSourceFile,
ts.setTextRange(
ts.createNodeArray([bootstrapImport, ...updatedSourceFile.statements]),
nodeFactory.createNodeArray([bootstrapImport, ...updatedSourceFile.statements]),
sourceFile.statements,
),
);
Expand Down