Skip to content

refactor(@ngtools/webpack): initialize paths plugin in resolve options hook#20116

Merged
alan-agius4 merged 1 commit intoangular:masterfrom
clydin:webpack5/paths-plugin
Feb 23, 2021
Merged

refactor(@ngtools/webpack): initialize paths plugin in resolve options hook#20116
alan-agius4 merged 1 commit intoangular:masterfrom
clydin:webpack5/paths-plugin

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Feb 22, 2021

This change reduces the number of different Webpack resolver factory hooks required to initialize the compiler plugins.
Webpack 5 also requires the path plugin to be configured earlier in the process and the options hook provides that ability.

…s hook

This change reduces the number of different Webpack resolver factory hooks required to initialize the compiler plugins.
Webpack 5 also requires the path plugin to be configured earlier in the process and the options hook provides that ability.
@clydin clydin added the target: major This PR is targeted for the next major release label Feb 22, 2021
@google-cla google-cla bot added the cla: yes label Feb 22, 2021
@clydin clydin requested a review from alan-agius4 February 22, 2021 15:18
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 23, 2021
@alan-agius4 alan-agius4 merged commit 2e3b954 into angular:master Feb 23, 2021
@clydin clydin deleted the webpack5/paths-plugin branch February 24, 2021 11:24
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants