Skip to content

test(@schematics/angular): add missing unit test for skipTests flag#21151

Merged
filipesilva merged 1 commit intoangular:masterfrom
phhien203:phhien203-patch-1
Jun 18, 2021
Merged

test(@schematics/angular): add missing unit test for skipTests flag#21151
filipesilva merged 1 commit intoangular:masterfrom
phhien203:phhien203-patch-1

Conversation

@phhien203
Copy link
Copy Markdown

add missing unit test of skipTests flag for component, class, directive, and pipe

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 17, 2021
@phhien203
Copy link
Copy Markdown
Author

@googlebot I fixed it.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@phhien203
Copy link
Copy Markdown
Author

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 17, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 18, 2021
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@filipesilva filipesilva merged commit 9cd8be6 into angular:master Jun 18, 2021
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants