Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Jul 1, 2021

The @ampproject/remapping package is now used for sourcemap processing instead of Webpack for differential loading and i18n processing. This dependency is already used within the recently added JavaScript optimizer refactoring and reduces the amount of code that needs to be loaded into each worker to support differential loading source maps. Testing with large output bundles (~12MB vendor bundles) resulted in an ~8% total build time improvement when using differential loading and source maps.

…fferential loading sourcemaps

The `@ampproject/remapping` package is now used for source map processing instead of Webpack for differential loading and i18n processing. This dependency is already used within the recently added JavaScript optimizer refactoring and reduces the amount of code that needs to be loaded into each worker to support differential loading sourcemaps.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 1, 2021
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@clydin clydin requested a review from alan-agius4 July 1, 2021 17:43
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 2, 2021
@clydin clydin merged commit 3c2fb5c into angular:master Jul 2, 2021
@clydin clydin deleted the jestworker-to-piscina branch July 2, 2021 15:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants