Skip to content

fix(@angular-devkit/build-angular): provide supported browsers to esbuild#21595

Merged
clydin merged 1 commit intoangular:masterfrom
alan-agius4:esbuild-support-browsers
Aug 18, 2021
Merged

fix(@angular-devkit/build-angular): provide supported browsers to esbuild#21595
clydin merged 1 commit intoangular:masterfrom
alan-agius4:esbuild-support-browsers

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

With this change we provide the list of supported browsers to Esbuild during CSS optimizations, so it can perform optimizations based on the browser support needed.

Closes #21594

@alan-agius4 alan-agius4 requested a review from clydin August 18, 2021 10:28
@google-cla google-cla bot added the cla: yes label Aug 18, 2021
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed cla: yes labels Aug 18, 2021
@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 18, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot added the cla: yes label Aug 18, 2021
@alan-agius4 alan-agius4 reopened this Aug 18, 2021
Copy link
Copy Markdown
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good test case for this? Maybe at least one so we don't accidentally regress. I think there used to be some IE11 style related ones before IE support was removed that maybe could be repurposed. Or even the Edge one in the issue.

@alan-agius4
Copy link
Copy Markdown
Collaborator Author

@clydin test added. Would eventually like to move these tests to use the new test harness.

…uild

With this change we provide the list of supported browsers to Esbuild during CSS optimizations, so it can perform optimizations based on the browser support needed.

Closes #21594
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2021
@clydin clydin merged commit aba54ae into angular:master Aug 18, 2021
@alan-agius4 alan-agius4 deleted the esbuild-support-browsers branch August 18, 2021 15:05
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component level CSS: rgba() transforms to #rrggbbaa hex value without respecting browserslist config

2 participants