Skip to content

refactor(@angular-devkit/build-angular): remove differential loading stats generation #21613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipesilva merged 1 commit into from
Aug 23, 2021
Merged

refactor(@angular-devkit/build-angular): remove differential loading stats generation #21613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 4 additions & 36 deletions packages/angular_devkit/build_angular/src/webpack/utils/stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,9 @@ export function formatSize(size: number): string {
}

export type BundleStatsData = [files: string, names: string, size: number | string];

export type ChunkType = 'modern' | 'legacy' | 'unknown';

export interface BundleStats {
initial: boolean;
stats: BundleStatsData;
chunkType: ChunkType;
}

export function generateBundleStats(info: {
Expand All @@ -47,7 +43,6 @@ export function generateBundleStats(info: {
names?: string[];
initial?: boolean;
rendered?: boolean;
chunkType?: ChunkType;
}): BundleStats {
const size = typeof info.size === 'number' ? info.size : '-';
const files =
Expand All @@ -57,10 +52,8 @@ export function generateBundleStats(info: {
.join(', ') ?? '';
const names = info.names?.length ? info.names.join(', ') : '-';
const initial = !!info.initial;
const chunkType = info.chunkType || 'unknown';

return {
chunkType,
initial,
stats: [files, names, size],
};
Expand All @@ -79,11 +72,9 @@ function generateBuildStatsTable(
const changedEntryChunksStats: BundleStatsData[] = [];
const changedLazyChunksStats: BundleStatsData[] = [];

let initialModernTotalSize = 0;
let initialLegacyTotalSize = 0;
let modernFileSuffix: string | undefined;
let initialTotalSize = 0;

for (const { initial, stats, chunkType } of data) {
for (const { initial, stats } of data) {
const [files, names, size] = stats;

const data: BundleStatsData = [
Expand All @@ -94,24 +85,8 @@ function generateBuildStatsTable(

if (initial) {
changedEntryChunksStats.push(data);

if (typeof size === 'number') {
switch (chunkType) {
case 'modern':
initialModernTotalSize += size;
if (!modernFileSuffix) {
const match = files.match(/-(es20\d{2}|esnext)/);
modernFileSuffix = match?.[1].toString().toUpperCase();
}
break;
case 'legacy':
initialLegacyTotalSize += size;
break;
default:
initialModernTotalSize += size;
initialLegacyTotalSize += size;
break;
}
initialTotalSize += size;
}
} else {
changedLazyChunksStats.push(data);
Expand All @@ -126,14 +101,7 @@ function generateBuildStatsTable(

if (showTotalSize) {
bundleInfo.push([]);
if (initialModernTotalSize === initialLegacyTotalSize) {
bundleInfo.push([' ', 'Initial Total', formatSize(initialModernTotalSize)].map(bold));
} else {
bundleInfo.push(
[' ', 'Initial ES5 Total', formatSize(initialLegacyTotalSize)].map(bold),
[' ', `Initial ${modernFileSuffix} Total`, formatSize(initialModernTotalSize)].map(bold),
);
}
bundleInfo.push([' ', 'Initial Total', formatSize(initialTotalSize)].map(bold));
}
}

Expand Down