Skip to content

fix(@schematics/angular): add browserslist configuration in library projects #21663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Aug 27, 2021
Merged

fix(@schematics/angular): add browserslist configuration in library projects #21663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48a150c
fix(@schematics/angular): add browserslist configuration in library p…
alan-agius4 Aug 27, 2021
23375b4
fix(@angular-devkit/build-angular): set browserslist defaults
alan-agius4 Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/angular_devkit/build_angular/src/utils/build-browser-features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ export class BuildBrowserFeatures {
readonly supportedBrowsers: string[];

constructor(private projectRoot: string) {
// By default, browserslist defaults are too inclusive
// https://github.com/browserslist/browserslist/blob/83764ea81ffaa39111c204b02c371afa44a4ff07/index.js#L516-L522

// We change the default query to browsers that Angular support.
// https://angular.io/guide/browser-support
browserslist.defaults = [
'last 1 Chrome version',
'last 1 Firefox version',
'last 2 Edge major versions',
'last 2 Safari major versions',
'last 2 iOS major versions',
'Firefox ESR',
];

this.supportedBrowsers = browserslist(undefined, { path: this.projectRoot });
}

Expand Down
16 changes: 16 additions & 0 deletions packages/schematics/angular/library/files/.browserslistrc.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# This file is used by the build system to adjust CSS and JS output to support the specified browsers below.
# For additional information regarding the format and rule options, please see:
# https://github.com/browserslist/browserslist#queries

# For the full list of supported browsers by the Angular framework, please see:
# https://angular.io/guide/browser-support

# You can see what browsers were selected by your queries by running:
# npx browserslist

last 1 Chrome version
last 1 Firefox version
last 2 Edge major versions
last 2 Safari major versions
last 2 iOS major versions
Firefox ESR