docs: update ng deploy suggestions#22274
Merged
filipesilva merged 1 commit intoangular:masterfrom Dec 3, 2021
fmalcher:ngdeploysuggestions
Merged
docs: update ng deploy suggestions#22274filipesilva merged 1 commit intoangular:masterfrom fmalcher:ngdeploysuggestions
filipesilva merged 1 commit intoangular:masterfrom
fmalcher:ngdeploysuggestions
Conversation
This package seems not to be maintained anymore. Hence, it shouldn't be suggested with ng deploy.
Contributor
|
+1 for |
Collaborator
|
Once approved by our dev-rel, https://angular.io/guide/deployment should also be updated. |
alan-agius4
added
action: review
mgechev
reviewed
Dec 2, 2021
mgechev
previously requested changes
Dec 2, 2021
Member
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Left a comment inline. Thank you for keeping our list of builders up to date!
alan-agius4
approved these changes
Dec 2, 2021
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default output of
ng deploy.@zeit/ng-deploy. This package seems to be unmaintained, it should therefore not be suggested in the default output. See https://github.com/vercel/ng-deploy-vercel/issues/14 or https://github.com/vercel/ng-deploy-vercel/issues/12angular-cli-ghpagesby @JohannesHoppe and me to the suggestions. This can be discussed ;-)