chore(bug): improved the ember to angular regex#239
Merged
jkuri merged 1 commit intoangular:masterfrom Feb 23, 2016
Merged
Conversation
The regex was ovewriting a URL on ng version Fixes angular#203
Contributor
|
Thanks for the fix @Brocco. I was planning to fix this but stuck with virus in bed for the last four days. I will check this later today, also |
| } | ||
| string = string.replace(/ember-cli/g, 'angular-cli'); | ||
| string = string.replace(/ember/g, 'ng'); | ||
| string = string.replace(/ember-cli(?!.com)/g, 'angular-cli'); |
Contributor
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex was ovewriting a URL on ng version
Fixes #203