Skip to content

fix(@angular-devkit/build-angular): wait during file watching to improve multi-save rebuilds for esbuild builder#24159

Merged
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/watch-group-capture
Oct 31, 2022
Merged

fix(@angular-devkit/build-angular): wait during file watching to improve multi-save rebuilds for esbuild builder#24159
dgp1130 merged 1 commit intoangular:mainfrom
clydin:esbuild/watch-group-capture

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Oct 28, 2022

When using the experimental esbuild-based browser application builder in watch mode, the file watcher will now wait 250ms from a reported file event before triggering a rebuild. The change allows the rebuild to better capture groups of file changes. This can happen when using an IDE while editing multiple files and would otherwise result in multiple rebuilds where a single rebuild would be ideal.

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Oct 28, 2022
…ove multi-save rebuilds for esbuild builder

When using the experimental esbuild-based browser application builder in watch mode, the file watcher will now
wait 250ms from a reported file event before triggering a rebuild. The change allows the rebuild to better
capture groups of file changes. This can happen when using an IDE while editing multiple files and would otherwise
result in multiple rebuilds where a single rebuild would be ideal.
@clydin clydin force-pushed the esbuild/watch-group-capture branch from ee6b426 to cbb565f Compare October 28, 2022 18:50
@clydin clydin requested a review from alan-agius4 October 28, 2022 19:15
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 31, 2022
@dgp1130 dgp1130 merged commit 7c2b846 into angular:main Oct 31, 2022
@clydin clydin deleted the esbuild/watch-group-capture branch October 31, 2022 17:10
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants