refactor(@angular-devkit/core): remove unneeded import statements from Node.js file host#24184
Merged
dgp1130 merged 1 commit intoangular:mainfrom Nov 4, 2022
Merged
Conversation
clydin
force-pushed
the
core/cleanup-host-imports
branch
from
ede12d0 to
4be858a
Compare
…m Node.js file host This reduces the number of imports for the Node.js file host classes. The `fs` default import was only used in one place and named imports were already in use for `node:fs` which allowed the one use to be converted to a named import. The type only import for `chokidar` was also only used in one type annotation and was moved to the type annotation directly.
clydin
force-pushed
the
core/cleanup-host-imports
branch
from
4be858a to
f7cab20
Compare
clydin
added
the
action: review
dgp1130
approved these changes
Nov 4, 2022
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of imports for the Node.js file host classes. The
fsdefault import was only used in one place and named imports were already in use fornode:fswhich allowed the one use to be converted to a named import. The type only import forchokidarwas also only used in one type annotation and was moved to the type annotation directly.