Skip to content

chore(libs): completely removed current install/uninstall tasks#242

Merged
jkuri merged 1 commit intoangular:masterfrom
jkuri:libs-install-uninstall
Feb 24, 2016
Merged

chore(libs): completely removed current install/uninstall tasks#242
jkuri merged 1 commit intoangular:masterfrom
jkuri:libs-install-uninstall

Conversation

@jkuri
Copy link
Copy Markdown
Contributor

@jkuri jkuri commented Feb 23, 2016

As it was agreed I removed this two tasks.

@jkuri jkuri force-pushed the libs-install-uninstall branch from bd87190 to c05c872 Compare February 23, 2016 17:36
@filipesilva
Copy link
Copy Markdown
Contributor

Can you also check package.json for any dependency you might have added for this feature? I know glob had to go from dev dep to normal dep in ef96ef2, but I don't know if there was anything else you added initially.

@jkuri
Copy link
Copy Markdown
Contributor Author

jkuri commented Feb 24, 2016

If I remember correctly I didn't added any new dependency for this tasks, but I can check if glob is used somewhere else and if not, remove it.

@filipesilva
Copy link
Copy Markdown
Contributor

It had to be moved to dependencies on account of #233, but you're right, something else might need it now.

If nothing does need it though, it should go back to devDependencies.

@jkuri
Copy link
Copy Markdown
Contributor Author

jkuri commented Feb 24, 2016

/tests/runner.js and /tests/acceptance/init.spec.js also uses glob..

@filipesilva
Copy link
Copy Markdown
Contributor

That might be why it was a devDep I guess... I don't think those tests run outside of the dev environment.

@jkuri jkuri force-pushed the libs-install-uninstall branch from c05c872 to af1c0fa Compare February 24, 2016 09:14
@jkuri
Copy link
Copy Markdown
Contributor Author

jkuri commented Feb 24, 2016

Moved glob to devDependencies.

@hansl
Copy link
Copy Markdown
Contributor

hansl commented Feb 24, 2016

LGTM 👍

@jkuri jkuri merged commit af1c0fa into angular:master Feb 24, 2016
@jkuri jkuri deleted the libs-install-uninstall branch February 24, 2016 17:54
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants