perf(@angular-devkit/build-angular): add vendor chunking to server builder#24223
Merged
dgp1130 merged 1 commit intoangular:mainfrom Nov 15, 2022
Merged
Conversation
alan-agius4
added
target: minor
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
vendor-chunk-server-builder
branch
from
75b96bc to
3b6d0fc
Compare
clydin
approved these changes
Nov 14, 2022
…ilder With this change we add the `vendorChunk` option in the server builder. This option should only be used in development as it is intended to be used to improve the incremental re-build time. This improves the rebuild time as Webpack will have less modules to analyse during a change in the application. Below, we can see the impact this change has in a `ng new` application. Without vendor chunking ``` $ ng run ssr-vendor:server:development --watch --no-vendor-chunk Build at: 2022-11-14T08:42:27.089Z - Hash: 0325905b63e43ddb - Time: 15357ms Build at: 2022-11-14T08:42:37.565Z - Hash: 05cb180a02524656 - Time: 2498ms Build at: 2022-11-14T08:42:40.325Z - Hash: c5a6996ed1924088 - Time: 1862ms Build at: 2022-11-14T08:42:43.043Z - Hash: 92ce99f38a769c19 - Time: 1516ms ``` With vendor chunking ``` $ ng run ssr-vendor:server:development --watch --vendor-chunk Build at: 2022-11-14T08:43:13.631Z - Hash: 28bdfea879d01a31 - Time: 15561ms Build at: 2022-11-14T08:43:19.396Z - Hash: cc95e2b6cb403111 - Time: 1705ms Build at: 2022-11-14T08:43:21.296Z - Hash: 204138490668a16c - Time: 848ms Build at: 2022-11-14T08:43:23.835Z - Hash: 4fa294b261917944 - Time: 824ms ```
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
vendor-chunk-server-builder
branch
from
3b6d0fc to
4905a92
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we add the
vendorChunkoption in the server builder. This option should only be used in development as it is intended to be used to improve the incremental re-build time.This improves the rebuild time as Webpack will have less modules to analyse during a change in the application. Below, we can see the impact this change has in a
ng newapplication.Without vendor chunking
With vendor chunking
FYI: @AndrewKushnir & @mgechev