Skip to content

fix(@angular-devkit/build-angular): update loader-utils to 3.2.1 #24243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgp1130 merged 3 commits into from
Nov 16, 2022
Merged

fix(@angular-devkit/build-angular): update loader-utils to 3.2.1 #24243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee6421
fix(@angular-devkit/build-angular): update `loader-utils` to `3.2.1`
alan-agius4 Nov 16, 2022
8107d77
test(@angular/cli): update NPM range in npm-7 test
alan-agius4 Nov 16, 2022
3c53774
test(@angular/cli): remove `node:assert` usage.
alan-agius4 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
"less-loader": "11.0.0",
"license-checker": "^25.0.0",
"license-webpack-plugin": "4.0.2",
"loader-utils": "3.2.0",
"loader-utils": "3.2.1",
"magic-string": "0.26.2",
"mini-css-extract-plugin": "2.6.1",
"minimatch": "5.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"less": "4.1.3",
"less-loader": "11.0.0",
"license-webpack-plugin": "4.0.2",
"loader-utils": "3.2.0",
"loader-utils": "3.2.1",
"mini-css-extract-plugin": "2.6.1",
"minimatch": "5.1.0",
"open": "8.4.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/legacy-cli/e2e/tests/misc/npm-7.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ export default async function () {
}

try {
// Install version >=7.5.6
await npm('install', '--global', 'npm@>=7.5.6');
// Install version ^7.5.6
await npm('install', '--global', 'npm@^7.5.6');

// Ensure `ng update` does not show npm warning
const { stderr: stderrUpdate1 } = await ng('update', ...extraArgs);
Expand Down
5 changes: 3 additions & 2 deletions tests/legacy-cli/e2e/tests/update/update-secure-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { createNpmConfigForAuthentication } from '../../utils/registry';
import { expectToFail } from '../../utils/utils';
import { isPrereleaseCli } from '../../utils/project';
import { getActivePackageManager } from '../../utils/packages';
import assert from 'node:assert';

export default async function () {
// The environment variable has priority over the .npmrc
Expand Down Expand Up @@ -41,6 +40,8 @@ export default async function () {
await createNpmConfigForAuthentication(true, true);

const error = await expectToFail(() => exec('yarn', 'ng', 'update', ...extraArgs));
assert.match(error.message, /not allowed to access package/);
if (!/not allowed to access package/.test(error.message)) {
throw new Error('Error did not match not allowed to access package.');
}
}
}
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7317,6 +7317,11 @@ loader-utils@3.2.0:
resolved "https://registry.yarnpkg.com/loader-utils/-/loader-utils-3.2.0.tgz#bcecc51a7898bee7473d4bc6b845b23af8304d4f"
integrity sha512-HVl9ZqccQihZ7JM85dco1MvO9G+ONvxoGa9rkhzFsneGLKSUg1gJf9bWzhRhcvm2qChhWpebQhP44qxjKIUCaQ==

loader-utils@3.2.1:
version "3.2.1"
resolved "https://registry.yarnpkg.com/loader-utils/-/loader-utils-3.2.1.tgz#4fb104b599daafd82ef3e1a41fb9265f87e1f576"
integrity sha512-ZvFw1KWS3GVyYBYb7qkmRM/WwL2TQQBxgCK62rlvm4WpVQ23Nb4tYjApUlfjrEGvOs7KHEsmyUn75OHZrJMWPw==

loader-utils@^2.0.0:
version "2.0.2"
resolved "https://registry.yarnpkg.com/loader-utils/-/loader-utils-2.0.2.tgz#d6e3b4fb81870721ae4e0868ab11dd638368c129"
Expand Down