Skip to content

Conversation

@nicojs
Copy link
Contributor

@nicojs nicojs commented Nov 22, 2022

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #24294

What is the new behavior?

Expose the build-in karma config to anyone that wants to use it.

// karma.conf.js
const setDefaultConfig = require('@angular-devkit/build-angular/src/builders/karma/karma.conf.js');
module.exports = function(config) {
 setDefaultConfig(config);
 config.set({
   // my own custom overrides
 });
}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Expose build in karma config to anyone that wants to use it.

For example:

```js
// karma.conf.js
const setDefaultConfig = require('@angular-devkit/build-angular/src/builders/karma/karma.conf.js');
module.exports = function(config) {
  setDefaultConfig(config);
  config.set({
    // my own custom overrides
  });
}
```
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 22, 2022
@alan-agius4
Copy link
Collaborator

Thanks for your contribution. But this has been superseded by #24458

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants