Skip to content

Conversation

@jvalkeejarvi
Copy link
Contributor

@jvalkeejarvi jvalkeejarvi commented Nov 25, 2022

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Sass quietDeps option is not working anymore. Warnings for 3rd party sass files appear again after updating to Angular 15.

What is the new behavior?

Warnings for 3rd party sass files are hidden again.

@google-cla
Copy link

google-cla bot commented Nov 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jvalkeejarvi jvalkeejarvi changed the title fix(@angular-devkit/build-angular): incorrect sass quietDeps and verb… fix(@angular-devkit/build-angular): incorrect sass quietDeps and verbose Nov 25, 2022
@jvalkeejarvi jvalkeejarvi changed the title fix(@angular-devkit/build-angular): incorrect sass quietDeps and verbose fix(@angular-devkit/build-angular): incorrect sass quietDeps and verbose options Nov 25, 2022
@jvalkeejarvi jvalkeejarvi force-pushed the fix-sass-verbose-option branch from 968a3b9 to 84650a5 Compare November 25, 2022 08:43
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you please amend the commit message and include the body to be a bit more descriptive?

fix(@angular-devkit/build-angular): correctly set Sass quietDeps and verbose options

The logic to set these options was flipped which caused the warnings to be displayed when verbose was disabled.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 25, 2022
…verbose options

The logic to set these options was flipped which caused the warnings to
be displayed when verbose was disabled.
@jvalkeejarvi jvalkeejarvi force-pushed the fix-sass-verbose-option branch from 84650a5 to 8ed8909 Compare November 25, 2022 13:15
@jvalkeejarvi jvalkeejarvi changed the title fix(@angular-devkit/build-angular): incorrect sass quietDeps and verbose options fix(@angular-devkit/build-angular): correctly set Sass quietDeps and verbose options Nov 25, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 25, 2022
@angular-robot angular-robot bot merged commit 012393d into angular:main Nov 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants