Skip to content

fix(@angular/cli): error if Angular compiler is used in a schematic #24662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angular-robot merged 1 commit into from
Feb 7, 2023
Merged

fix(@angular/cli): error if Angular compiler is used in a schematic #24662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/angular/cli/src/command-builder/utilities/schematic-engine-host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { readFileSync } from 'fs';
import { parse as parseJson } from 'jsonc-parser';
import { createRequire } from 'module';
import { dirname, resolve } from 'path';
import { TextEncoder } from 'util';
Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used an import for this, even though it's available globally, because for some reason the global variable wasn't in the typings.

import { Script } from 'vm';
import { assertIsError } from '../../utilities/error';

Expand Down Expand Up @@ -211,6 +212,12 @@ function wrap(
__dirname: schematicDirectory,
__filename: schematicFile,
Buffer,
// TextEncoder is used by the compiler to generate i18n message IDs. See:
// https://github.com/angular/angular/blob/main/packages/compiler/src/i18n/digest.ts#L17
// It is referenced globally, because it may be run either on the browser or the server.
// Usually Node exposes it globally, but in order for it to work, our custom context
// has to expose it too. Issue context: https://github.com/angular/angular/issues/48940.
TextEncoder,
console,
process,
get global() {
Expand Down