test: update module resolution E2E for latest framework changes #24971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
e2e/module-mapping
branch
2 times, most recently
from
63183dd to
183122c
Compare
The `module-resolution-core-mapping` E2E test modifies the tsconfig path mapping settings to change the location of `@angular/common`. However, with recent changes to the framework, the `@angular/platform-browser` package now also depends on `@angular/common/http` (a secondary export). This secondary export was not mapped in the test which resulted in the test failing since the build could not find the export. Related FW change: angular/angular@81e7d15
clydin
force-pushed
the
e2e/module-mapping
branch
from
183122c to
b1545b7
Compare
dgp1130
approved these changes
Apr 6, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
module-resolution-core-mappingE2E test modifies the tsconfig path mapping settings to change the location of@angular/common. However, with recent changes to the framework, the@angular/platform-browserpackage now also depends on@angular/common/http(a secondary export). This secondary export was not mapped in the test which resulted in the test failing since the build could not find the export.Related FW change: angular/angular@81e7d15