Skip to content

perf(@angular-devkit/build-angular): only import esbuild watcher when in watch mode #24976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angular-robot merged 1 commit into from
Apr 11, 2023
Merged

perf(@angular-devkit/build-angular): only import esbuild watcher when in watch mode #24976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { NormalizedBrowserOptions, normalizeOptions } from './options';
import { shutdownSassWorkerPool } from './sass-plugin';
import { Schema as BrowserBuilderOptions } from './schema';
import { createStylesheetBundleOptions } from './stylesheets';
import { ChangedFiles, createWatcher } from './watcher';
import type { ChangedFiles } from './watcher';

interface RebuildState {
codeRebuild?: BundlerContext;
Expand Down Expand Up @@ -678,6 +678,7 @@ export async function* buildEsbuildBrowser(
}

// Setup a watcher
const { createWatcher } = await import('./watcher');
const watcher = createWatcher({
polling: typeof userOptions.poll === 'number',
interval: userOptions.poll,
Expand Down