Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Apr 11, 2023

Minor directory restructure to better organize the Angular compiler plugin code files.
The remainder of the Angular specific files for the Angular esbuild compiler plugin are now
within the angular subdirectory of the esbuild-based browser application builder.
Types and functionality that were used by both the AOT and JIT compilation classes within
the esbuild Angular compiler plugin have been extracted into a common base class that
both now extend. This removes duplicate code from both classes.

clydin added 2 commits April 10, 2023 18:08
… in angular directory

Minor directory restructure to better organize the Angular compiler plugin code files.
The remainder of the Angular specific files for the Angular esbuild compiler plugin are now
within the `angular` subdirectory of the esbuild-based browser application builder.
…ngular JIT/AOT compilation

Types and functionality that were used by both the AOT and JIT compilation classes within
the esbuild Angular compiler plugin have been extracted into a common base class that
both now extend. This removes duplicate code from both classes.
@clydin clydin force-pushed the esbuild/ng-compiler-restructure branch from 6216c1c to 71d35d7 Compare April 11, 2023 02:08
@clydin clydin added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 11, 2023
@clydin clydin requested a review from alan-agius4 April 11, 2023 17:27
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2023
@angular-robot angular-robot bot merged commit 587c4d0 into angular:main Apr 12, 2023
@clydin clydin deleted the esbuild/ng-compiler-restructure branch April 12, 2023 18:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants