Skip to content

perf(@angular-devkit/build-angular): asynchronously delete output path in esbuild builder #24992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angular-robot merged 1 commit into from
Apr 12, 2023
Merged

perf(@angular-devkit/build-angular): asynchronously delete output path in esbuild builder #24992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import assert from 'node:assert';
import { constants as fsConstants } from 'node:fs';
import fs from 'node:fs/promises';
import path from 'node:path';
import { deleteOutputDir } from '../../utils';
import { copyAssets } from '../../utils/copy-assets';
import { assertIsError } from '../../utils/error';
import { transformSupportedBrowsersToTargets } from '../../utils/esbuild-targets';
Expand Down Expand Up @@ -623,7 +622,13 @@ export async function* buildEsbuildBrowser(
if (shouldWriteResult) {
// Clean output path if enabled
if (userOptions.deleteOutputPath) {
deleteOutputDir(normalizedOptions.workspaceRoot, userOptions.outputPath);
if (normalizedOptions.outputPath === normalizedOptions.workspaceRoot) {
context.logger.error('Output path MUST not be workspace root directory!');

return;
}

await fs.rm(normalizedOptions.outputPath, { force: true, recursive: true, maxRetries: 3 });
}

// Create output directory if needed
Expand Down