Skip to content

fix(@angular-devkit/build-angular): update esbuild builder complete log #25063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angular-robot merged 1 commit into from
Apr 25, 2023
Merged

fix(@angular-devkit/build-angular): update esbuild builder complete log #25063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ async function execute(
logBuildStats(context, metafile, initialFiles);

const buildTime = Number(process.hrtime.bigint() - startTime) / 10 ** 9;
context.logger.info(`Complete. [${buildTime.toFixed(3)} seconds]`);
context.logger.info(`Application bundle generation complete. [${buildTime.toFixed(3)} seconds]`);

return executionResult;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/basic/rebuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getGlobalVariable } from '../../utils/env';

export default async function () {
const esbuild = getGlobalVariable('argv')['esbuild'];
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/;

const port = await ngServe();
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/utils/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export async function ngServe(...args: string[]) {
const port = await findFreePort();

const esbuild = getGlobalVariable('argv')['esbuild'];
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;

await execAndWaitForOutputToMatch(
'ng',
Expand Down