Skip to content

perf(@angular-devkit/build-angular): do not inline sourcemap when using vite dev-server #25082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angular-robot merged 1 commit into from
Apr 27, 2023
Merged

perf(@angular-devkit/build-angular): do not inline sourcemap when using vite dev-server #25082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,12 @@ export async function setupServer(
return;
}

const code = Buffer.from(codeContents).toString('utf-8');
const mapContents = outputFiles.get(file + '.map')?.contents;

return {
// Remove source map URL comments from the code if a sourcemap is present.
// Vite will inline and add an additional sourcemap URL for the sourcemap.
code: mapContents ? code.replace(/^\/\/# sourceMappingURL=[^\r\n]*/gm, '') : code,
code: Buffer.from(codeContents).toString('utf-8'),
map: mapContents && Buffer.from(mapContents).toString('utf-8'),
};
},
Expand Down Expand Up @@ -262,7 +261,7 @@ export async function setupServer(
// Resource files are handled directly.
// Global stylesheets (CSS files) are currently considered resources to workaround
// dev server sourcemap issues with stylesheets.
if (extension !== '.js' && extension !== '.html') {
if (extension !== '.html') {
const outputFile = outputFiles.get(parsedUrl.pathname);
if (outputFile) {
const mimeType = lookupMimeType(extension);
Expand Down