fix(@angular-devkit/build-angular): exclude @angular/platform-server/init from unsafe optimizations
#25083
Conversation
…/init` from unsafe optimizations `@angular/platform-server/init` entry-point is side-effectful and thus it's not safe to perform advanced optimizations.
alan-agius4
added
target: rc
|
|
||
| if (optimize) { | ||
| const angularPackage = /[\\/]node_modules[\\/]@angular[\\/]/.test(this.resourcePath); | ||
| // @angular/platform-server/init entry-point has side-effects. |
There was a problem hiding this comment.
what about other side-effect entry-points? we might be adding arbitrary ones. Can't we rely on the sideEffects field in package.json? We also have localize/init IIRC (but yes- that one is usually not in user code I think)
There was a problem hiding this comment.
Once we move this into the actual FW packaging and bundling process, these checks can all be removed.
Also, adding any side effect entry points should be done with care since import statement usage then can become order dependent. As well as also causing deoptimizations in other aspects of the build pipeline.
There was a problem hiding this comment.
@angular/localize/init is not in users code indeed.
There was a problem hiding this comment.
Yes exactly, just need to be careful in adding new entry-points. I don't think the current solution is ideal (and I'm not aware of the concrete plans going forward)
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
@angular/platform-server/initentry-point is side-effectful and thus it's not safe to perform advanced optimizations.