fix(@angular-devkit/build-angular): avoid CommonJS warnings for relative imports with esbuild builders #25167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/relative-commonjs-checker
branch
2 times, most recently
from
8d1f3ea to
53090c9
Compare
clydin
added
the
action: review
alan-agius4
reviewed
May 9, 2023
packages/angular_devkit/build_angular/src/builders/browser-esbuild/commonjs-checker.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
esbuild/relative-commonjs-checker
branch
2 times, most recently
from
3fa3715 to
2f4a7f1
Compare
…ive imports with esbuild builders When using the esbuild-based browser application builder, CommonJS file warnings were incorrectly being issued for relative file imports. The CommonJS warnings are only intended to be generated for node module imports.
clydin
force-pushed
the
esbuild/relative-commonjs-checker
branch
from
2f4a7f1 to
70695fc
Compare
alan-agius4
approved these changes
May 9, 2023
alan-agius4
reviewed
May 9, 2023
| * @returns True, if specifier is potentially relative; false, otherwise. | ||
| */ | ||
| function isPotentialRelative(specifier: string): boolean { | ||
| if (specifier[0] === '.') { |
Collaborator
There was a problem hiding this comment.
Can be changed to just return specifier[0] === '.'
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder, CommonJS file warnings were incorrectly being issued for relative file imports. The CommonJS warnings are only intended to be generated for node module imports.