fix(@angular-devkit/build-angular): attempt relative global script read first in esbuild builder #25203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad first in esbuild builder When using a global script (`scripts` option) with the esbuild-based browser application builder, an attempt to read the script as a relative path from the workspace root will be performed first. This avoids the need to perform a potentially expensive module resolution attempt for files that are directly available and also ensures the relative paths are given priority over any potential modules with the same name. This matches prior behavior that also preferred relative paths.
clydin
added
target: patch
alan-agius4
approved these changes
May 15, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a global script (
scriptsoption) with the esbuild-based browser application builder, an attempt to read the script as a relative path from the workspace root will be performed first. This avoids the need to perform a potentially expensive module resolution attempt for files that are directly available and also ensures the relative paths are given priority over any potential modules with the same name. This matches prior behavior that also preferred relative paths.Closes #25198