Skip to content

refactor(@angular-devkit/build-angular): use helper to setup esbuild plugin load caching#25237

Merged
alan-agius4 merged 2 commits intoangular:mainfrom
clydin:esbuild/watchfiles-angular
May 19, 2023
Merged

refactor(@angular-devkit/build-angular): use helper to setup esbuild plugin load caching#25237
alan-agius4 merged 2 commits intoangular:mainfrom
clydin:esbuild/watchfiles-angular

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented May 17, 2023

Within the esbuild-based browser application builder, a helper function has been introduced
to streamline the use of the load result cache within the internal plugins. This removes
repeat code that would otherwise be needed.

@clydin clydin added the target: minor This PR is targeted for the next minor release label May 17, 2023
@clydin clydin force-pushed the esbuild/watchfiles-angular branch 2 times, most recently from e115c6a to 5b73aad Compare May 18, 2023 01:48
…plugin load caching

Within the esbuild-based browser application builder, a helper function has been introduced
to streamline the use of the load result cache within the internal plugins. This removes
repeat code that would otherwise be needed. The ability to use a load result cache with the
global script processing has also been added but has not yet been enabled.
@clydin clydin force-pushed the esbuild/watchfiles-angular branch from 5b73aad to 99a3ad8 Compare May 18, 2023 03:06
@clydin clydin marked this pull request as ready for review May 18, 2023 03:06
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 18, 2023
@clydin clydin requested a review from alan-agius4 May 18, 2023 13:40
…hing for stylesheets in esbuild builder

The stylesheet related plugins for the esbuild-based browser application builder will now cache intermediate
load results when in watch mode. This reduces the potential amount of processing needed during a rebuild for
both `ng build --watch` and `ng serve`.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 19, 2023
@alan-agius4 alan-agius4 merged commit 8336ad8 into angular:main May 19, 2023
@clydin clydin deleted the esbuild/watchfiles-angular branch May 19, 2023 10:23
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants