Skip to content

build: minor cleanup of bazel build rules#25243

Merged
clydin merged 1 commit intoangular:mainfrom
clydin:build/bazel-rule-cleanup-1
May 22, 2023
Merged

build: minor cleanup of bazel build rules#25243
clydin merged 1 commit intoangular:mainfrom
clydin:build/bazel-rule-cleanup-1

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented May 19, 2023

BUILD files for each package have had outdated glob excludes removed. Additionally, some src args have been reduced to a single file where possible. The root bazel ignore file has also been expanded to include all node module directories in each package. The ignore file does not appear to currently support globs so each path has been individually specified.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 19, 2023
@clydin clydin force-pushed the build/bazel-rule-cleanup-1 branch 4 times, most recently from d39567e to 9a9aeb6 Compare May 19, 2023 15:17
BUILD files for each package have had outdated glob excludes removed.
Additionally, some src args have been reduced to a single file where possible.
The root bazel ignore file has also been expanded to include all node module
directories in each package. The ignore file does not appear to currently support
globs so each path has been individually specified.
@clydin clydin force-pushed the build/bazel-rule-cleanup-1 branch from 9a9aeb6 to a0ab5ec Compare May 19, 2023 18:13
@clydin clydin marked this pull request as ready for review May 19, 2023 18:53
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 19, 2023
@clydin clydin requested a review from alan-agius4 May 19, 2023 18:53
@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2023
@clydin clydin merged commit 11e0a51 into angular:main May 22, 2023
@clydin clydin deleted the build/bazel-rule-cleanup-1 branch May 22, 2023 13:36
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants