Skip to content

fix(@angular-devkit/build-angular): correctly set overridden compiler… #25296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
May 31, 2023
Merged

fix(@angular-devkit/build-angular): correctly set overridden compiler… #25296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/webpack/plugins/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ export function createIvyPlugin(
};

if (tsConfig.options.target === undefined || tsConfig.options.target < ScriptTarget.ES2022) {
tsConfig.options.target = ScriptTarget.ES2022;
compilerOptions.target = ScriptTarget.ES2022;
// If 'useDefineForClassFields' is already defined in the users project leave the value as is.
// Otherwise fallback to false due to https://github.com/microsoft/TypeScript/issues/45995
// which breaks the deprecated `@Effects` NGRX decorator and potentially other existing code as well.
tsConfig.options.useDefineForClassFields ??= false;
compilerOptions.useDefineForClassFields ??= false;

wco.logger.warn(
'TypeScript compiler options "target" and "useDefineForClassFields" are set to "ES2022" and ' +
Expand Down