Skip to content

feat(@angular-devkit/build-angular): add initial application builder implementation#25384

Merged
clydin merged 1 commit intoangular:mainfrom
alan-agius4:application-builder
Jun 23, 2023
Merged

feat(@angular-devkit/build-angular): add initial application builder implementation#25384
clydin merged 1 commit intoangular:mainfrom
alan-agius4:application-builder

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This commits add the initial application builder schema and build configuration and refactors several files.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 15, 2023
@alan-agius4 alan-agius4 force-pushed the application-builder branch 2 times, most recently from 9759883 to 954c1fa Compare June 15, 2023 11:50
Comment thread packages/angular_devkit/build_angular/src/builders/application/index.ts Outdated
@alan-agius4 alan-agius4 force-pushed the application-builder branch 4 times, most recently from a633662 to 838b95b Compare June 15, 2023 12:21
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Jun 15, 2023
@alan-agius4 alan-agius4 marked this pull request as ready for review June 15, 2023 12:36
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 15, 2023
@alan-agius4 alan-agius4 requested a review from clydin June 15, 2023 18:12
Copy link
Copy Markdown
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about avoiding nested generator functions.

Comment thread packages/angular_devkit/build_angular/src/builders/application/index.ts Outdated
@alan-agius4 alan-agius4 force-pushed the application-builder branch from 838b95b to a9c83af Compare June 23, 2023 18:24
…implementation

This commits add the initial application builder schema and build configuration and refactors several files.
@alan-agius4 alan-agius4 force-pushed the application-builder branch from a9c83af to 63210d9 Compare June 23, 2023 18:24
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2023
@clydin clydin merged commit c05c83b into angular:main Jun 23, 2023
@alan-agius4 alan-agius4 deleted the application-builder branch June 23, 2023 19:52
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants