Skip to content

refactor(@angular-devkit/build-angular): use direct fs caching for font inlining#25407

Merged
clydin merged 1 commit intoangular:mainfrom
clydin:direct-font-caching
Jun 22, 2023
Merged

refactor(@angular-devkit/build-angular): use direct fs caching for font inlining#25407
clydin merged 1 commit intoangular:mainfrom
clydin:direct-font-caching

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Jun 20, 2023

The cacache package was only minimally used within the font inlining post-build processing. The usage has now been replaced with direct filesystem access and key hashing to cache any font files. This not only lowers the overall dependency count but also provides a small performance improvement by removing the need to resolve, load, and evaluate additional JavaScript at build time.

…nt inlining

The `cacache` package was only minimally used within the font inlining post-build
processing. The usage has now been replaced with direct filesystem access and key
hashing to cache any font files. This not only lowers the overall dependency count
but also provides a small performance improvement by removing the need to resolve,
load, and evaluate additional JavaScript at build time.
@clydin clydin marked this pull request as ready for review June 20, 2023 15:51
@clydin clydin requested a review from alan-agius4 June 20, 2023 15:51
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 20, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 22, 2023
@clydin clydin merged commit 518149d into angular:main Jun 22, 2023
@clydin clydin deleted the direct-font-caching branch June 22, 2023 14:47
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants