refactor(@angular-devkit/schematics-cli): use latest version of jasmine for schematics#25694
refactor(@angular-devkit/schematics-cli): use latest version of jasmine for schematics#25694santoshyadavdev wants to merge 1 commit intoangular:mainfrom
Conversation
|
Hi Santosh, check out our commit message guidelines for the linting rule to pass 😉 |
Sorry raised a PR after years, let me fix this |
…ne for schematics
7139f89 to
7dab968
Compare
|
@JeanMeche should be ok now. But I was wondering if we should keep jasmine, my first thought was to remove it, but we can discuss and decide. |
|
The error looks not related to this PR |
|
In May, the Angular Robot tried to upgrade and got rejected because Jasmine 5 doesn't run on Node 16 anymore: angular/angular#50284 @santoshyadavdev I am all ears regarding dropping Jasmine. What are your reasons? |
|
Ahh makes sense for build failure.
For jasmine,I mean it's a starter project, I think devs should chose the
tool they like.
And most of the project I have seen use jest, does that make sense?.
…On Sat, 19 Aug 2023, 13:49 Rainer Hahnekamp, ***@***.***> wrote:
In May, the Angular Robot tried to upgrade and got rejected because
Jasmine 5 doesn't run on Node 16 anymore: angular/angular#50284
<angular/angular#50284>
@santoshyadavdev <https://github.com/santoshyadavdev> I am all ears
regarding dropping Jasmine. What are your reasons?
—
Reply to this email directly, view it on GitHub
<#25694 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC27EBYI7IYZENGFO3YQYJLXWCR5VANCNFSM6AAAAAA3VRTKQM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Understood. I'd like to add that there are also reasons to use Jasmine instead of Jest:
Either way, official support for Jest will finally come to Angular as well. There is already experimental support since version 16. So devs will be able to choose. If you are interested in more, I've written a whole article about it: https://dev.to/this-is-angular/angular-testing-in-2023-past-present-and-future-j5m |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Schematics project install jasmine, but its of very old version.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently jasmine version installed is very old
Issue Number: N/A
What is the new behavior?
Install the latest version of jasmine
Does this PR introduce a breaking change?
Other information