Skip to content

refactor: remove polynomial regular expression#25743

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:regexp-inline-critical
Aug 30, 2023
Merged

refactor: remove polynomial regular expression#25743
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:regexp-inline-critical

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This change updates the critical css processor to remove the need for a Polynomial regular expression.

Addresses: https://github.com/angular/angular-cli/security/code-scanning/51
Closes #25742

@alan-agius4 alan-agius4 requested a review from clydin August 30, 2023 10:11
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Aug 30, 2023
@alan-agius4 alan-agius4 force-pushed the regexp-inline-critical branch 2 times, most recently from 39075ab to 6531493 Compare August 30, 2023 11:47
This change updates the critical css processor to remove the need for a Polynomial regular expression.

Addresses: https://github.com/angular/angular-cli/security/code-scanning/51
Closes angular#25742
@alan-agius4 alan-agius4 force-pushed the regexp-inline-critical branch from 6531493 to d9651da Compare August 30, 2023 12:48
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 30, 2023
@alan-agius4 alan-agius4 merged commit f917b67 into angular:main Aug 30, 2023
@alan-agius4 alan-agius4 deleted the regexp-inline-critical branch August 30, 2023 15:02
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Polynomial regular expression used on uncontrolled data

2 participants