Skip to content

refactor(@angular-devkit/build-angular): use whenStable private API in route extractor #25916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Sep 28, 2023
Merged

refactor(@angular-devkit/build-angular): use whenStable private API in route extractor #25916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/angular_devkit/build_angular/src/utils/routes-extractor/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ ts_library(
"@npm//@angular/platform-server",
"@npm//@angular/router",
"@npm//@types/node",
"@npm//rxjs",
],
)
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/utils/routes-extractor/extractor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ import {
Type,
createPlatformFactory,
platformCore,
ɵwhenStable as whenStable,
} from '@angular/core';
import {
INITIAL_CONFIG,
ɵINTERNAL_SERVER_PLATFORM_PROVIDERS as INTERNAL_SERVER_PLATFORM_PROVIDERS,
} from '@angular/platform-server';
import { Route, Router, ɵloadChildren as loadChildrenHelper } from '@angular/router';
import { first } from 'rxjs/operators'; // Import from `/operators` to support rxjs 6 which is still supported by the Framework.

interface RouterResult {
route: string;
Expand Down Expand Up @@ -98,7 +98,7 @@ export async function* extractRoutes(
}

// Wait until the application is stable.
await applicationRef.isStable.pipe(first((isStable) => isStable)).toPromise();
await whenStable(applicationRef);

const injector = applicationRef.injector;
const router = injector.get(Router);
Expand Down