build: re-enable Material tests#25930
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Oct 9, 2023
Merged
Conversation
crisbeto
added
action: review
angular-robot
bot
added
the
area: build & ci
Member
Author
|
I suspect this shows a breakage introduced in angular/components#27792. It didn't show up since the breakage came up while the test was disabled. |
crisbeto
force-pushed
the
material-tests-cleanup
branch
2 times, most recently
from
747e1c3 to
a9c80e0
Compare
alan-agius4
added
action: cleanup
Collaborator
|
@crisbeto looks like https://github.com/angular/angular-cli/blob/a9c80e00d7d93459f5efdb7b2de2127ca9468d7a/tests/legacy-cli/e2e/tests/build/material.ts needs to be updated since ng-new apps are not standalone by default. |
Re-enables Material tests that had to be disabled during the TS 5.2 update.
crisbeto
force-pushed
the
material-tests-cleanup
branch
from
a9c80e0 to
7a345e6
Compare
Member
Author
|
@alan-agius4 it's fixed now. |
crisbeto
added
action: review
alan-agius4
approved these changes
Oct 9, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables Material tests that had to be disabled during the TS 5.2 update.