fix(@angular-devkit/build-angular): normalize exclude path#26245
Merged
alan-agius4 merged 1 commit intoNov 7, 2023
Conversation
36640d5 to
8e77fc3
Compare
Contributor
Author
|
Update:
|
fix(@angular-devkit/build-angular): normalize exclude path
5c2ec31 to
eb978d5
Compare
Contributor
Author
|
Update:
@alan-agius4 -> Please, review. |
alan-agius4
approved these changes
Nov 7, 2023
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution
1 task
Contributor
Author
|
@alan-agius4 -> I hope we are good to merge this? |
Collaborator
|
@akhilbiju, yes, CI is green. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The issue arises from passing
excludepaths directly to the glob method, which can confuse users when they provide relative project roots or backslashes. This problem doesn't occur withincludepaths because those are automatically normalized.Issue Number: #26239
What is the new behavior?
The
excludepaths are now normalized for common user errors, such as the use of backslashes or relative project roots. This also unifies, to a certain extent, howincludeandexcludepaths are transformed internally by the builder.The remaining normalization steps for

includeare already informed to the developer, so now all the normalization forinclude&excludeare either unified or documented.Does this PR introduce a breaking change?
Other information