Skip to content

build: update to TypeScript 5.3 #26455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Nov 22, 2023
Merged

build: update to TypeScript 5.3 #26455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions goldens/public-api/angular_devkit/build_angular/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

```ts

/// <reference types="@types/node/http" />
Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We saw similar references being added in @angular/localize as well angular/angular#52572 (comment)

/// <reference types="@types/node/ts4.8/http" />
/// <reference types="node" />

import { BuilderContext } from '@angular-devkit/architect';
Expand Down
2 changes: 2 additions & 0 deletions goldens/public-api/angular_devkit/core/node/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

```ts

/// <reference types="@types/node/fs" />
/// <reference types="@types/node/ts4.8/fs" />
/// <reference types="node" />

import { Observable } from 'rxjs';
Expand Down
2 changes: 2 additions & 0 deletions goldens/public-api/angular_devkit/core/node/testing/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

```ts

/// <reference types="@types/node/fs" />
/// <reference types="@types/node/ts4.8/fs" />
/// <reference types="node" />

import * as fs from 'fs';
Expand Down
3 changes: 3 additions & 0 deletions goldens/public-api/angular_devkit/schematics/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

```ts

/// <reference types="@types/node/ts4.8/url" />
/// <reference types="@types/node/url" />

import { BaseException } from '@angular-devkit/core';
import { JsonValue } from '@angular-devkit/core';
import { logging } from '@angular-devkit/core';
Expand Down
3 changes: 3 additions & 0 deletions goldens/public-api/angular_devkit/schematics/tasks/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

```ts

/// <reference types="@types/node/ts4.8/url" />
/// <reference types="@types/node/url" />

// @public (undocumented)
export class NodePackageInstallTask implements TaskConfigurationGenerator<NodePackageTaskOptions> {
constructor(workingDirectory?: string);
Expand Down
3 changes: 3 additions & 0 deletions goldens/public-api/angular_devkit/schematics/testing/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

```ts

/// <reference types="@types/node/ts4.8/url" />
/// <reference types="@types/node/url" />

import { JsonValue } from '@angular-devkit/core';
import { logging } from '@angular-devkit/core';
import { Observable } from 'rxjs';
Expand Down
3 changes: 3 additions & 0 deletions goldens/public-api/angular_devkit/schematics/tools/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

```ts

/// <reference types="@types/node/ts4.8/url" />
/// <reference types="@types/node/url" />

import { BaseException } from '@angular-devkit/core';
import { JsonObject } from '@angular-devkit/core';
import { JsonValue } from '@angular-devkit/core';
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
"tree-kill": "1.2.2",
"ts-node": "^10.9.1",
"tslib": "2.6.2",
"typescript": "5.2.2",
"typescript": "5.3.2",
"undici": "5.27.2",
"verdaccio": "5.27.0",
"verdaccio-auth-memory": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"ng-packagr": "^17.0.0 || ^17.1.0-next.0",
"protractor": "^7.0.0",
"tailwindcss": "^2.0.0 || ^3.0.0",
"typescript": ">=5.2 <5.3"
"typescript": ">=5.2 <5.4"
},
"peerDependenciesMeta": {
"@angular/localize": {
Expand Down
4 changes: 2 additions & 2 deletions packages/ngtools/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
"dependencies": {},
"peerDependencies": {
"@angular/compiler-cli": "^17.0.0 || ^17.1.0-next.0",
"typescript": ">=5.2 <5.3",
"typescript": ">=5.2 <5.4",
"webpack": "^5.54.0"
},
"devDependencies": {
"@angular-devkit/core": "0.0.0-PLACEHOLDER",
"@angular/compiler": "17.1.0-next.1",
"@angular/compiler-cli": "17.1.0-next.1",
"typescript": "5.2.2",
"typescript": "5.3.2",
"webpack": "5.89.0"
}
}
8 changes: 4 additions & 4 deletions packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
load("//tools:defaults.bzl", "ts_library")

# files fetched on 2023-06-02 from
# https://github.com/microsoft/TypeScript/releases/tag/v5.2.2
# files fetched on 2023-11-22 from
# https://github.com/microsoft/TypeScript/releases/tag/v5.2.3

# Commands to download:
# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.2.2/lib/typescript.d.ts -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.d.ts
# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.2.2/lib/typescript.js -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.js
# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.3.2/lib/typescript.d.ts -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.d.ts
# curl https://raw.githubusercontent.com/microsoft/TypeScript/v5.3.2/lib/typescript.js -o packages/schematics/angular/third_party/github.com/Microsoft/TypeScript/lib/typescript.js

licenses(["notice"]) # Apache 2.0

Expand Down
Loading