fix(@angular-devkit/build-angular): check namespaced Sass variables when rebasing URLs#26577
Merged
clydin merged 1 commit intoangular:mainfrom Dec 5, 2023
Merged
Conversation
…hen rebasing URLs The `@use` Sass directive allows Sass variables to be accessed via a namespace. This was previously not checked when performing URL path rebasing on imported Sass stylesheets. These type of Sass variable references are now also ignored when attempting to rebase URL paths during loading. The final rebased URL now also does not add a leading relative prefix indicator (`./`) unless not already present.
clydin
added
action: review
alan-agius4
approved these changes
Dec 5, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@useSass directive allows Sass variables to be accessed via a namespace. This was previously not checked when performing URL path rebasing on imported Sass stylesheets. These type of Sass variable references are now also ignored when attempting to rebase URL paths during loading. The final rebased URL now also does not add a leading relative prefix indicator (./) unless not already present.Closes #26570