Skip to content

refactor(@angular-devkit/build-angular): use for loop instead of filter and forEach #26921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Jan 22, 2024
Merged

refactor(@angular-devkit/build-angular): use for loop instead of filter and forEach #26921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/angular_devkit/build_angular/src/tools/esbuild/bundler-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,12 @@ export class BundlerContext {
if (this.incremental) {
// When incremental always add any files from the load result cache
if (this.#loadCache) {
this.#loadCache.watchFiles
.filter((file) => !isInternalAngularFile(file))
// watch files are fully resolved paths
.forEach((file) => this.watchFiles.add(file));
for (const file of this.#loadCache.watchFiles) {
if (!isInternalAngularFile(file)) {
// watch files are fully resolved paths
this.watchFiles.add(file);
}
}
}
}
}
Expand All @@ -247,10 +249,12 @@ export class BundlerContext {
// currently enabled with watch mode where watch files are needed.
if (this.incremental) {
// Add input files except virtual angular files which do not exist on disk
Object.keys(result.metafile.inputs)
.filter((input) => !isInternalAngularFile(input))
// input file paths are always relative to the workspace root
.forEach((input) => this.watchFiles.add(join(this.workspaceRoot, input)));
for (const input of Object.keys(result.metafile.inputs)) {
if (!isInternalAngularFile(input)) {
// input file paths are always relative to the workspace root
this.watchFiles.add(join(this.workspaceRoot, input));
}
}
}

// Return if the build encountered any errors
Expand Down