Skip to content

test: generalize webpack direct E2E chunk size testing #27135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Feb 21, 2024
Merged

test: generalize webpack direct E2E chunk size testing #27135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/legacy-cli/e2e/tests/packages/webpack/test-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { normalize } from 'path';
import { join, normalize } from 'path';
import { createProjectFromAsset } from '../../../utils/assets';
import { expectFileSizeToBeUnder, expectFileToMatch, replaceInFile } from '../../../utils/fs';
import { execWithEnv } from '../../../utils/process';
import { readdir } from 'node:fs/promises';
import assert from 'node:assert';

export default async function () {
const webpackCLIBin = normalize('node_modules/.bin/webpack-cli');
Expand All @@ -14,9 +16,17 @@ export default async function () {

// Note: these sizes are without Build Optimizer or any advanced optimizations in the CLI.
await expectFileSizeToBeUnder('dist/app.main.js', 650 * 1024);
await expectFileSizeToBeUnder('dist/604.app.main.js', 1024);
await expectFileSizeToBeUnder('dist/988.app.main.js', 1024);
await expectFileSizeToBeUnder('dist/896.app.main.js', 1024);
const outputFiles = await readdir('dist', { withFileTypes: true });
let fileCount = 0;
for (const outputFile of outputFiles) {
if (outputFile.isFile() && outputFile.name.endsWith('.app.main.js')) {
++fileCount;
await expectFileSizeToBeUnder(join(outputFile.path, outputFile.name), 1024);
}
}
if (fileCount !== 3) {
assert.fail('Expected three additional Webpack output chunk files.');
}

// test resource urls without ./
await replaceInFile('app/app.component.ts', './app.component.html', 'app.component.html');
Expand Down