Skip to content

refactor(@schematics/angular): remove internal linkCli ng-new option #27284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Mar 14, 2024
Merged

refactor(@schematics/angular): remove internal linkCli ng-new option #27284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65483c5
refactor(@schematics/angular): remove internal `linkCli` ng-new option
alan-agius4 Mar 14, 2024
334555f
refactor(@angular-devkit/schematics): deprecate `NodePackageLinkTask`
alan-agius4 Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/public-api/angular_devkit/schematics/tasks/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class NodePackageInstallTask implements TaskConfigurationGenerator<NodePa
workingDirectory?: string;
}

// @public (undocumented)
// @public @deprecated (undocumented)
export class NodePackageLinkTask implements TaskConfigurationGenerator<NodePackageTaskOptions> {
constructor(packageName?: string | undefined, workingDirectory?: string | undefined);
// (undocumented)
Expand Down
8 changes: 7 additions & 1 deletion packages/angular_devkit/schematics/tasks/package-manager/link-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@
import { TaskConfiguration, TaskConfigurationGenerator } from '../../src';
import { NodePackageName, NodePackageTaskOptions } from './options';

/**
* @deprecated since version 18. Create a custom task if required.
*/
export class NodePackageLinkTask implements TaskConfigurationGenerator<NodePackageTaskOptions> {
quiet = true;

constructor(public packageName?: string, public workingDirectory?: string) {}
constructor(
public packageName?: string,
public workingDirectory?: string,
) {}

toConfiguration(): TaskConfiguration<NodePackageTaskOptions> {
return {
Expand Down
7 changes: 0 additions & 7 deletions packages/schematics/angular/ng-new/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
} from '@angular-devkit/schematics';
import {
NodePackageInstallTask,
NodePackageLinkTask,
RepositoryInitializerTask,
} from '@angular-devkit/schematics/tasks';
import { Schema as ApplicationOptions } from '../application/schema';
Expand Down Expand Up @@ -77,12 +76,6 @@ export default function (options: NgNewOptions): Rule {
packageManager: options.packageManager,
}),
);
if (options.linkCli) {
packageTask = context.addTask(
new NodePackageLinkTask('@angular/cli', options.directory),
[packageTask],
);
}
}
if (!options.skipGit) {
const commit =
Expand Down
6 changes: 0 additions & 6 deletions packages/schematics/angular/ng-new/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@
"type": "boolean",
"default": false
},
"linkCli": {
"description": "Link the CLI to the global version (internal development only).",
"type": "boolean",
"default": false,
"visible": false
},
"skipGit": {
"description": "Do not initialize a git repository.",
"type": "boolean",
Expand Down