perf(@angular/ssr): prevent potential stampede in entry-points cache #28506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybrist
commented
Sep 26, 2024
Contributor
Author
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
Feel free to close as "not worth it". I'm just having flashbacks to issues with cache stampedes during bootup, so I'm a bit overly sensitive about it. :)
hybrist
commented
Sep 26, 2024
hybrist
force-pushed
the
jk-entry-points-cache
branch
from
e2b408e to
4562c95
Compare
alan-agius4
reviewed
Sep 26, 2024
alan-agius4
approved these changes
Sep 26, 2024
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, one tiny nit.
hybrist
force-pushed
the
jk-entry-points-cache
branch
from
4562c95 to
03e1d2c
Compare
alan-agius4
approved these changes
Sep 26, 2024
If multiple concurrent requests hit `getEntryPointExports`, all of them would previously see the cache miss for entry point. With this change, only the first request will and the others can leverage the cache. This can be important when instances are added to a pool under high traffic.
hybrist
force-pushed
the
jk-entry-points-cache
branch
from
03e1d2c to
436bcf6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple concurrent requests hit
getEntryPointExports, all ofthem would previously see the cache miss for entry point. With this
change, only the first request will and the others can leverage the
cache.
This can be important when instances are added to a pool under high
traffic.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information