Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ import {
writeResponseToNodeResponse,
} from '@angular/ssr/node';
import express from 'express';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { join } from 'node:path';

const serverDistFolder = dirname(fileURLToPath(import.meta.url));
const browserDistFolder = resolve(serverDistFolder, '../<%= browserDistDirectory %>');
const browserDistFolder = join(import.meta.dirname, '../<%= browserDistDirectory %>');

const app = express();
const angularApp = new AngularNodeAppEngine();
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/ssr/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('SSR Schematic', () => {
expect(scripts['serve:ssr:test-app']).toBe(`node dist/test-app/node-server/server.mjs`);

const serverFileContent = tree.readContent('/projects/test-app/src/server.ts');
expect(serverFileContent).toContain(`resolve(serverDistFolder, '../public')`);
expect(serverFileContent).toContain(`join(import.meta.dirname, '../public')`);
});

it(`removes "outputPath.browser" when it's an empty string`, async () => {
Expand Down
3 changes: 1 addition & 2 deletions scripts/build-packages-dist.mts
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@ import { BuiltPackage } from '@angular/ng-dev';
import { execSync } from 'node:child_process';
import { chmodSync, copyFileSync, mkdirSync, rmSync } from 'node:fs';
import { dirname, join } from 'node:path';
import { fileURLToPath } from 'node:url';
import sh from 'shelljs';

/** Name of the Bazel tag that will be used to find release package targets. */
const releaseTargetTag = 'release-package';

/** Path to the project directory. */
const projectDir = join(dirname(fileURLToPath(import.meta.url)), '../');
const projectDir = join(import.meta.dirname, '../');

/** Command that runs Bazel. */
const bazelCmd = process.env.BAZEL || `pnpm -s bazel`;
Expand Down
5 changes: 2 additions & 3 deletions scripts/build-schema.mts
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@

import { spawn } from 'node:child_process';
import { rm } from 'node:fs/promises';
import { dirname, join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { join, resolve } from 'node:path';

const __dirname = dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;
const baseDir = resolve(`${__dirname}/..`);
const bazelCmd = process.env.BAZEL ?? `pnpm -s bazel`;
const distRoot = join(baseDir, '/dist-schema/');
Expand Down
5 changes: 2 additions & 3 deletions scripts/build.mts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
import { spawn } from 'node:child_process';
import { COPYFILE_FICLONE } from 'node:constants';
import fs from 'node:fs';
import path, { dirname, join, relative, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { dirname, join, relative, resolve } from 'node:path';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;
const baseDir = resolve(`${__dirname}/..`);
const bazelCmd = process.env.BAZEL ?? `pnpm -s bazel`;
const distRoot = join(baseDir, '/dist');
Expand Down
4 changes: 2 additions & 2 deletions scripts/create.mts
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ import assert from 'node:assert';
import * as child_process from 'node:child_process';
import { copyFile, readFile, rm, writeFile } from 'node:fs/promises';
import * as path from 'node:path';
import { fileURLToPath, pathToFileURL } from 'node:url';
import { pathToFileURL } from 'node:url';
import build from './build.mjs';
import { packages } from './packages.mjs';

export interface CreateOptions extends Record<string, unknown> {
_: string[];
}

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;

async function _exec(command: string, args: string[], opts: { cwd?: string }) {
const { status, error, stderr, stdout } = child_process.spawnSync(command, args, { ...opts });
Expand Down
5 changes: 2 additions & 3 deletions scripts/devkit-admin.mts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
*/

import colors from 'ansi-colors';
import path, { dirname } from 'node:path';
import { fileURLToPath } from 'node:url';
import path from 'node:path';
import yargsParser from 'yargs-parser';

const args = yargsParser(process.argv.slice(2), {
Expand All @@ -21,7 +20,7 @@ const args = yargsParser(process.argv.slice(2), {
const scriptName = args._.shift();

const cwd = process.cwd();
const scriptDir = dirname(fileURLToPath(import.meta.url));
const scriptDir = import.meta.dirname;
process.chdir(path.join(scriptDir, '..'));

const originalConsole = { ...console };
Expand Down
3 changes: 1 addition & 2 deletions scripts/json-help.mts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ import { spawnSync } from 'node:child_process';
import { promises as fs } from 'node:fs';
import * as os from 'node:os';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';
import create from './create.mjs';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;

export async function createTemporaryProject(): Promise<string> {
console.info('Creating temporary project...');
Expand Down
3 changes: 1 addition & 2 deletions scripts/snapshots.mts
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ import { execSync, spawnSync } from 'node:child_process';
import * as fs from 'node:fs';
import * as os from 'node:os';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';
import build from './build.mjs';
import jsonHelp, { createTemporaryProject } from './json-help.mjs';
import { PackageInfo, packages } from './packages.mjs';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;

// Added to the README.md of the snapshot. This is markdown.
const readmeHeaderFn = (name: string, snapshotRepo: string) => `
Expand Down
3 changes: 1 addition & 2 deletions scripts/templates.mts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
import lodash from 'lodash';
import * as fs from 'node:fs';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';
import { releasePackages } from './packages.mjs';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;

async function _runTemplate(inputPath: string, outputPath: string) {
inputPath = path.resolve(__dirname, inputPath);
Expand Down
3 changes: 1 addition & 2 deletions scripts/validate-user-analytics.mts
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ import lodash from 'lodash';
import assert from 'node:assert';
import * as fs from 'node:fs';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';
import {
EventCustomDimension,
EventCustomMetric,
UserCustomDimension,
} from '../packages/angular/cli/src/analytics/analytics-parameters.mjs';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const __dirname = import.meta.dirname;
const userAnalyticsTable = lodash.template(
fs.readFileSync(path.join(__dirname, './templates/user-analytics-table.ejs'), 'utf-8'),
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@types/express": "^4.17.17",
"@types/jasmine": "~4.3.0",
"@types/mime": "^3.0.0",
"@types/node": "^18.18.0",
"@types/node": "^20.17.19",
"jasmine-core": "~4.6.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,11 @@ export default async function () {
'src/server.ts': `
import { AngularNodeAppEngine, writeResponseToNodeResponse, isMainModule, createNodeRequestHandler } from '@angular/ssr/node';
import express from 'express';
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
import { join } from 'node:path';

export function app(): express.Express {
const server = express();
const serverDistFolder = dirname(fileURLToPath(import.meta.url));
const browserDistFolder = resolve(serverDistFolder, '../browser');
const browserDistFolder = join(import.meta.dirname, '../browser');
const angularNodeAppEngine = new AngularNodeAppEngine();

server.get('/api', (req, res) => res.json({ dataFromAPI: true }));
Expand Down
6 changes: 2 additions & 4 deletions tests/legacy-cli/e2e/tests/vite/ssr-entry-express.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,11 @@ export default async function () {
'src/server.ts': `
import { AngularNodeAppEngine, writeResponseToNodeResponse, isMainModule, createNodeRequestHandler } from '@angular/ssr/node';
import express from 'express';
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
import { join } from 'node:path';

export function app(): express.Express {
const server = express();
const serverDistFolder = dirname(fileURLToPath(import.meta.url));
const browserDistFolder = resolve(serverDistFolder, '../browser');
const browserDistFolder = join(import.meta.dirname, '../browser');
const angularNodeAppEngine = new AngularNodeAppEngine();

server.use('/api/**', (req, res) => res.json({ hello: 'foo' }));
Expand Down
5 changes: 2 additions & 3 deletions tests/legacy-cli/e2e/utils/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,13 @@ export function updateServerFileForWebpack(filepath: string): Promise<void> {
import { APP_BASE_HREF } from '@angular/common';
import { CommonEngine } from '@angular/ssr/node';
import express from 'express';
import { fileURLToPath } from 'node:url';
import { dirname, join, resolve } from 'node:path';
import { join, resolve } from 'node:path';
import bootstrap from './main.server';

// The Express app is exported so that it can be used by serverless Functions.
export function app(): express.Express {
const server = express();
const serverDistFolder = dirname(fileURLToPath(import.meta.url));
const serverDistFolder = import.meta.dirname;
const browserDistFolder = resolve(serverDistFolder, '../browser');
const indexHtml = join(serverDistFolder, 'index.server.html');

Expand Down