Skip to content

Revert "refactor: use platformBrowser instead of platformBrowserTesting #29950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Mar 27, 2025
Merged

Revert "refactor: use platformBrowser instead of platformBrowserTesting #29950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/angular/build/src/builders/karma/polyfills/init_test_bed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@
*/

import { getTestBed } from '@angular/core/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';

// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
// Initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
6 changes: 2 additions & 4 deletions packages/angular_devkit/build_angular/src/builders/jest/init-test-bed.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@
// `@angular-devkit/build-angular` rather than the user's workspace. Should look into virtual modules to support those use cases.

import { getTestBed } from '@angular/core/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';

// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
4 changes: 1 addition & 3 deletions packages/angular_devkit/build_angular/src/builders/karma/browser_builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,10 @@ function getBuiltInMainFile(): string {
const content = Buffer.from(
`
import { getTestBed } from '@angular/core/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';

// TODO(alanagius): replace with \`platformBrowserTesting\` once https://github.com/angular/angular/pull/60480 is released.
// Initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true
});
Expand Down
6 changes: 2 additions & 4 deletions packages/angular_devkit/build_angular/src/builders/web-test-runner/jasmine_runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
*/

import { getTestBed } from '@angular/core/testing';
import { platformBrowser } from '@angular/platform-browser';
import { BrowserTestingModule } from '@angular/platform-browser/testing';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
import {
getConfig,
sessionFailed,
Expand Down Expand Up @@ -65,8 +64,7 @@ export async function runJasmineTests(jasmineEnv) {
jasmine.DEFAULT_TIMEOUT_INTERVAL = config.defaultTimeoutInterval;

// Initialize `TestBed` automatically for users. This assumes we already evaluated `zone.js/testing`.
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
});
Expand Down