Skip to content

test(@angular/build): enable unit-test builder coverage tests #31208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

test(@angular/build): enable unit-test builder coverage tests #31208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/testing/builder/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ ts_project(
# resolvable in the test project.
":node_modules/@angular/ssr",
":node_modules/vitest",
":node_modules/@vitest/coverage-v8",
] + glob(["projects/**/*"]),
deps = [
":node_modules/@angular-devkit/architect",
Expand Down
1 change: 1 addition & 0 deletions modules/testing/builder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"@angular-devkit/architect": "workspace:*",
"@angular/ssr": "workspace:*",
"@angular-devkit/build-angular": "workspace:*",
"@vitest/coverage-v8": "3.2.4",
"rxjs": "7.8.2",
"vitest": "3.2.4"
}
Expand Down
10 changes: 5 additions & 5 deletions packages/angular/build/src/builders/unit-test/tests/options/code-coverage-exclude_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from '../setup';

describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
xdescribe('Option: "codeCoverageExclude"', () => {
describe('Option: "codeCoverageExclude"', () => {
beforeEach(async () => {
setupApplicationTarget(harness);
await harness.writeFiles({
Expand All @@ -31,8 +31,8 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
const summary = harness.readFile('coverage/coverage-summary.json');
expect(summary).toContain('"src/app/error.ts"');
const summary = harness.readFile('coverage/coverage-final.json');
expect(summary).toContain('src/app/error.ts"');
});

it('should exclude files from coverage that match the glob pattern', async () => {
Expand All @@ -44,8 +44,8 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
const summary = harness.readFile('coverage/coverage-summary.json');
expect(summary).not.toContain('"src/app/error.ts"');
const summary = harness.readFile('coverage/coverage-final.json');
expect(summary).not.toContain('src/app/error.ts"');
});
});
});
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/tests/options/code-coverage-reporters_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from '../setup';

describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
xdescribe('Option: "codeCoverageReporters"', () => {
describe('Option: "codeCoverageReporters"', () => {
beforeEach(async () => {
setupApplicationTarget(harness);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/tests/options/code-coverage_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from '../setup';

describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
xdescribe('Option: "codeCoverage"', () => {
describe('Option: "codeCoverage"', () => {
beforeEach(async () => {
setupApplicationTarget(harness);
});
Expand Down
77 changes: 77 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.