Skip to content

refactor(@angular/build): make runner optional in unit-test builder #31549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+5 −8
Merged

refactor(@angular/build): make runner optional in unit-test builder #31549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion goldens/public-api/angular/build/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export type UnitTestBuilderOptions = {
progress?: boolean;
providersFile?: string;
reporters?: SchemaReporter[];
runner: Runner;
runner?: Runner;
setupFiles?: string[];
tsConfig?: string;
watch?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export async function normalizeOptions(
include: options.include ?? ['**/*.spec.ts'],
exclude: options.exclude,
filter,
runnerName: runner,
runnerName: runner ?? 'vitest',
coverage: options.coverage
? {
all: options.coverageAll,
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/build/src/builders/unit-test/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"runner": {
"type": "string",
"description": "Specifies the test runner to use for test execution.",
"default": "vitest",
"enum": ["karma", "vitest"]
},
"browsers": {
Expand Down Expand Up @@ -267,5 +268,5 @@
}
},
"additionalProperties": false,
"required": ["runner"]
"required": []
}
6 changes: 1 addition & 5 deletions tests/legacy-cli/e2e/utils/vitest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ export async function applyVitestBuilder(): Promise<void> {
// Update to Vitest builder.
const test = project['architect']['test'];
test['builder'] = '@angular/build:unit-test';
test['options'] = {
tsConfig: test['options']['tsConfig'],
buildTarget: '::development',
runner: 'vitest',
};
test['options'] = {};
});

await updateJsonFile('tsconfig.spec.json', (tsconfig) => {
Expand Down