refactor(@angular/cli): migrate ng add to new package manager abstraction #31985
+203
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
area: performance
clydin
force-pushed
the
ng-add/pm-abstraction
branch
24 times, most recently
from
6404b94 to
b346764
Compare
…action This commit fully refactors the `ng add` command to use the new, centralized package manager abstraction. All package installation and metadata fetching logic now goes through the new API. This includes: - Using `createPackageManager` to detect the project's package manager. - Replacing `fetchPackageMetadata` with `packageManager.getRegistryMetadata`. - Replacing `fetchPackageManifest` with `packageManager.getManifest`. - Replacing the `install` and `installTemp` methods with the `packageManager.add` and `packageManager.acquireTempPackage` methods. This change improves security by eliminating `shell: true` execution as well as enhances reliability with better error handling and caching.
The `ng add` command's version discovery mechanism could be slow when the `latest` tag of a package was incompatible, as it would fall back to exhaustively fetching the manifest for every available version. This commit introduces a performance optimization that uses a heuristic-based search. The new logic first identifies the latest release within each major version line and checks only those for compatibility. This dramatically reduces the number of network requests in the common case where peer dependency conflicts align with major versions. The exhaustive, version-by-version search is retained as a fallback to ensure correctness in edge cases.
Removes the `viewCommandFieldArgFormatter` from the `bun` package manager descriptor. While `bun` supports field-filtered registry views, it is limited to a single field at a time. The current package manager abstraction requires support for multiple fields. This change ensures that the package manager abstraction for `bun` is more accurate and avoids potential issues with unsupported command arguments.
clydin
force-pushed
the
ng-add/pm-abstraction
branch
from
b346764 to
927a262
Compare
clydin
force-pushed
the
ng-add/pm-abstraction
branch
4 times, most recently
from
fe82d7a to
639bf98
Compare
clydin
force-pushed
the
ng-add/pm-abstraction
branch
from
639bf98 to
3277317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fully refactors the
ng addcommand to use the new, centralized package manager abstraction.All package installation and metadata fetching logic now goes through the new API. This includes:
createPackageManagerto detect the project's package manager.fetchPackageMetadatawithpackageManager.getRegistryMetadata.fetchPackageManifestwithpackageManager.getManifest.installandinstallTempmethods with thepackageManager.addandpackageManager.acquireTempPackagemethods.