Skip to content

fix(@angular/build): ensure locale base href retains leading slash #32040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alan-agius4 merged 1 commit into from
Dec 5, 2025
Merged

fix(@angular/build): ensure locale base href retains leading slash #32040

alan-agius4 merged 1 commit into from
Dec 5, 2025

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 5, 2025 •
edited
Loading

When baseHref is provided, getLocaleBaseHref was incorrectly adding a leading slash from the joined path. This commit removes calls stripLeadingSlash to ensure the leading slash is removed when appropriate.

Closes #32030

@alan-agius4 alan-agius4 requested a review from clydin December 5, 2025 10:43
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 5, 2025
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 5, 2025
@alan-agius4
fix(@angular/build): ensure locale base href retains leading slash
fb6348b 
When baseHref is provided, getLocaleBaseHref was incorrectly stripping the leading slash from the joined path. This commit removes the stripLeadingSlash call to ensure the leading slash is preserved when appropriate.

Closes angular#32030
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 5, 2025
@alan-agius4 alan-agius4 merged commit 38b16ea into angular:main Dec 5, 2025
37 checks passed
@alan-agius4 alan-agius4 deleted the base-href-leading branch December 5, 2025 17:16
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Dec 5, 2025

This PR was merged into the repository. The changes were merged into the following branches:

alan-agius4 added a commit that referenced this pull request Dec 5, 2025
@alan-agius4
fix(@angular/build): ensure locale base href retains leading slash (#…
0fc7d57 
…32040)

When baseHref is provided, getLocaleBaseHref was incorrectly adding a leading slash from the joined path. This commit removes calls `stripLeadingSlash` to ensure the leading slash is removed when appropriate.

(cherry picked from commit 38b16ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed merge: squash commits When the PR is merged, a squash and merge should be performed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leading slash added to baseHref

2 participants

@alan-agius4 @clydin